Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme with examples and operator usage #45

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 16, 2024

While working on datafusion-contrib/datafusion-dft#143 (to integrate these functions into dft) I noticed the README didn't mention the operator syntax. Also when I was writing some tests I would have found it helpful to have explicit examples

BTW they worked great in dft

Changes

  1. Add an example section
  2. List supported operators

@alamb
Copy link
Contributor Author

alamb commented Sep 16, 2024

FYI @samuelcolvin

Copy link
Collaborator

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Feel free to merge (I'm not merging now in case you want to add more)

@alamb
Copy link
Contributor Author

alamb commented Sep 16, 2024

LGTM.

Feel free to merge (I'm not merging now in case you want to add more)

If something additional occurs to me I'll make a new PR. Thanks @samuelcolvin

@alamb alamb merged commit 5738ff3 into datafusion-contrib:main Sep 16, 2024
7 checks passed
@alamb alamb deleted the alamb/readme branch September 16, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants